don't update versionFile configuration if .tagpr file already exists #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, even if a .tagpr file exists and the version file setting is empty, it still detects and updates the file. It is incorrect behavior.
Sometimes version files are intentionally set to an empty string, and in such cases, it is confusing to users to detect version files on tagpr's own. Also, since version file detection is done heuristically, false positives can occur.
After the initial setting, even if it is an empty string, the version file information should be changed by the developers themselves and should not be touched by tagpr.
This behavior was informed by @griffin-stewie. Thanks.